Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Hide max/avg potential for characters that will not use a relic #477

Open
thailyn opened this issue Jul 11, 2024 · 0 comments
Open

Comments

@thailyn
Copy link

thailyn commented Jul 11, 2024

Motivation

When looking at the relic insights graph or the max/avg potential columns on the relic tab, all of the suitable characters are shown or factored in, regardless of whether they are configured to use that relic set on the optimize tab. This can lead to the user thinking a relic might be an upgrade for a character, but actually the optimizer will never select it, or having a relic insights graph that is cluttered with irrelevant characters.

Goal

For the relic table columns "Selected Char Avg/Max Potential" and similar columns, do not include a character's potential in the calculations unless that character is configured to use that set on the optimize tab (or if the character is not in the character list, or the character has no sets selects on the optimize tab at all).

For the relic insights graph, do not show icons (for buckets) or rows (for top 10) for characters that are not configured to use that relic's set on the optimize tab (or, those other conditions mentioned above). If not showing them at all is not ideal, perhaps these could be just grayed out or otherwise have some indication that those characters do not use that relic set.

Obviously, this additional filtering can be behind a toggle or as new columns in the table, etc., if that is deemed more appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant