Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tech debt] Clean up / speed up relic potential scorer #516

Open
fribbels opened this issue Aug 15, 2024 · 2 comments
Open

[Tech debt] Clean up / speed up relic potential scorer #516

fribbels opened this issue Aug 15, 2024 · 2 comments

Comments

@fribbels
Copy link
Owner

Motivation

On page load, we score every single relic's potential against all characters. This n x m operation is growing pretty fast with 2000 relics and 60+ characters now, and this can take multiple seconds on page load

Goal

Look into if this is necessary and how we can optimize

@FI00ds
Copy link
Contributor

FI00ds commented Oct 23, 2024

maybe a settings option to only score for the top n characters in the priority list?

@fribbels
Copy link
Owner Author

I think we should analyze the scoring algorithm and look for repeated work - there's going to be a lot of calculations that can be cached between characters. For example all the 0.75/1/1/1 crit characters can probably reuse the same scoring results between each other

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants