Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Performance] Update relic / ornament set filtering algorithm #560

Open
fribbels opened this issue Sep 4, 2024 · 0 comments
Open

[Performance] Update relic / ornament set filtering algorithm #560

fribbels opened this issue Sep 4, 2024 · 0 comments

Comments

@fribbels
Copy link
Owner

fribbels commented Sep 4, 2024

Motivation

Currently we're generating the permutations of all possible relic and ornament sets in order to use O(1) lookup in the optimizer loop. For ornament sets this isnt an issue since there's 18 ^ 2 permutations, but relic sets are at 20 ^ 4 = 160000 and this will soon become unscalable.

Goal

There's probably two phases to this, the initial phase is to immediately reduce the size of this buffer with some bit packing as a short term improvement.

The long term fix is to pick a different set matching algorithm that doesn't require all this to be generated as an array. This will only become a problem at around our 48th relic set and then we'd be back at where we are today in terms of memory usage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant