Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tech Debt] Deprecate name and displayName fields #730

Open
FI00ds opened this issue Nov 24, 2024 · 0 comments
Open

[Tech Debt] Deprecate name and displayName fields #730

FI00ds opened this issue Nov 24, 2024 · 0 comments

Comments

@FI00ds
Copy link
Contributor

FI00ds commented Nov 24, 2024 •
edited
Loading

Description

With i18n being used for all displayed text, we no longer need to use the name and displayName properties from the Character and Lightcone types/classes

Remove them from the class and type, and replace any existing uses to instead reference the character/lightcone by their id
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Fribbels HSR Optimizer Kanban Board
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@FI00ds