Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate primaryKey in favour of primaryKeys #932

Open
peterdesmet opened this issue May 15, 2024 · 1 comment
Open

Deprecate primaryKey in favour of primaryKeys #932

peterdesmet opened this issue May 15, 2024 · 1 comment

Comments

@peterdesmet
Copy link
Member

For consistency, I think we should deprecate primaryKey in favour of primaryKeys:

Screenshot 2024-05-15 at 17 06 00

I notice myself typing primaryKeys (plural), forgetting that is not a property of Table Schema.

@khusmann
Copy link
Contributor

Hmmm isn't it more correct in the singular? Although the primary key for a table may be determined by multiple fields, there is only one primary key definition per table. Whereas many foreign key and unique key definitions can exist simultaneously in a given table, so the plural there makes sense.

I'm less familiar with DB design so maybe I'm missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants