-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--skip-errors doesn't work for packages #1639
Open
Comments
It looks like this is a more general error that we can't skip any error in the CLI for validating packages. In frictionless 5.17.0 with this reprex I get: frictionless validate --skip-errors "blank-label" https://raw.githubusercontent.com/splor-mg/reprex/main/reprex/20231228T143527/datapackage.json
When I validate the data file (or a standalone resource) the check is properly skipped: frictionless validate --skip-errors "blank-label" https://raw.githubusercontent.com/splor-mg/reprex/main/reprex/20231228T143527/data.csv
|
Good catch. I'll change the title of the ticket to reflect this. |
diego-oncoramedical
changed the title
Can't disable foreign key checks in CLI
--skip-errors doesn't work for packages
Apr 30, 2024
hansendx
added a commit
to hansendx/frictionless-py
that referenced
this issue
Jun 27, 2024
Add missing pass of checklist to validate method Fix frictionlessdata#1639
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Overview
Edit: In my case, I only tried foreign key checks, but as @fjuniorr noted below,
--skip-errors
appears to be broken for all errors when checking a package.When validating a package using the CLI,
--skip-errors
does not appear to disable foreign key checks. Validation passes if and only if the foreign keys are commented out in each table schema file.I'm running the following command:
frictionless validate --trusted --limit-errors 50 --skip-errors [see below] $OUTPUT_DIR/package.json
For the error slug, I've tried:
foreign-key
(from docs)foreign-key-error
(mentioned here)foreignKey
(from source code)foreignKeyError
(by analogy withforeign-key-error
)I've also tried all four at the same time, separated by commas with no intervening spaces.
Sample output:
Info
Environment:
App is running inside the official Python 3.12.1 Alpine Linux Docker image.
The requirements.txt file, in its entirety:
Package
The package consists of a few unremarkable CSVs:
Package JSON, presented as YAML for readability:
The text was updated successfully, but these errors were encountered: