Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an option to create a hook on fop:modules:hook (register a hook on a module) #163

Open
SebSept opened this issue Aug 27, 2021 · 4 comments
Labels
enhancement small improvement
Projects

Comments

@SebSept
Copy link
Contributor

SebSept commented Aug 27, 2021

Questions Answers
Command name fop:modules:hook (already exists)
Command description? Don't change the command, but add an option
Command parameters? --create (?)
Possible impacts? none except a simplier flow

when I run fop:modules:hook --module vueseclatees --hook displayTableauVueEclateeDispatch I have a message that this hook does not exists.
So I run the command fop:add-hook --name displayTableauVueEclateeDispatch which annoys me with a title and a description (#106) :(
Then I run the first command again.

Too long :(

Having an option create will not break anything and allow just to run the command again with the option to get what I want.

@SebSept SebSept added the enhancement small improvement label Aug 27, 2021
@ghost ghost added this to Backlog in 1.5 Oct 13, 2021
@tom-combet
Copy link
Contributor

I think we could even create the hook by default if it doesn't exist, WDYT?

@SebSept
Copy link
Contributor Author

SebSept commented Nov 4, 2022

Not creating it prevents typo, it's good for safety imo.

@tom-combet
Copy link
Contributor

Ah yea, I see. So let's add this option.
And when hook doesn't exist and the option is not provided, we can ask the user if he wants to create the hook?

@SebSept
Copy link
Contributor Author

SebSept commented Nov 4, 2022

yes, that will be more user friendly :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement small improvement
Projects
1.5
Backlog
Development

No branches or pull requests

2 participants