Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Squash commit ? #178

Open
ghost opened this issue Oct 13, 2021 · 4 comments
Open

Squash commit ? #178

ghost opened this issue Oct 13, 2021 · 4 comments
Labels
enhancement small improvement question Further information is requested

Comments

@ghost
Copy link

ghost commented Oct 13, 2021

Describe the bug

When I look at the latest version, shouldn't we group the commits

When prestashop asks me to do so I complain but it's still cleaner
@ghost ghost added bug Something isn't working enhancement small improvement and removed bug Something isn't working labels Oct 13, 2021
@SebSept
Copy link
Contributor

SebSept commented Oct 13, 2021

you mean, squash all the commits from dev into a single one when merging dev into master ?
What's the real problem ?

@SebSept SebSept added the question Further information is requested label Oct 13, 2021
@ghost
Copy link
Author

ghost commented Oct 14, 2021 •
edited by ghost

Je voulais dire dans nos PR essayé d'avoir moins de commits et plus compréhensible.

  • Add xxx
  • oups
  • csfixer
  • again

Pourrait devenir que Add xxx

Je parle surtout pour moi :D pour les prochaines PR du coup

@SebSept
Copy link
Contributor

SebSept commented Oct 14, 2021

Ah, oui, oki 🙂.
C'est une recommandation qui pourrait rentrer dans des recommandations de dev. Dans le fichier Contributing ?

@ghost
Copy link
Author

ghost commented Oct 14, 2021

Oui ça me semble pas mal comme recommandation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement small improvement question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SebSept