Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate command fop:shop:status #254

Open
Grezor opened this issue Jul 5, 2022 · 3 comments
Open

Duplicate command fop:shop:status #254

Grezor opened this issue Jul 5, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@Grezor
Copy link

Grezor commented Jul 5, 2022

PrestaShop version(s)

1.7.8.6

Php version

7.4

Fop Console version

dev

Operating system

windows

command

fop:shop:status

Describe the bug

Hello,
This may not be a bug, just an information

when you type: php bin/console list fop

There are two times the command :

  • fop:shop-status Display shops statuses
  • fop:shop:status [fop:shop-status] Display shops statuses

see attached image
image

regards,
Geoffrey / Grezor

@Grezor Grezor added the bug Something isn't working label Jul 5, 2022
@nenes25
Copy link
Member

nenes25 commented Jul 6, 2022

Hello @Grezor,

It's not a bug, but a feature related with the alias of the commands.
It's also the case for some others.
The real question behind this issue is if this alias are still needed.

WDYT ping @jf-viguier @SebSept @tom-combet

@Grezor
Copy link
Author

Grezor commented Jul 7, 2022

Hello @nenes25

Thanks for the feedback. Yes I had seen that some have other aliases.
If you want I can delete the command: fop:shop-status.

to keep the same uniform => fop:shop:status
@jf-viguier @SebSept @tom-combet

@tom-combet
Copy link
Contributor

As @SebSept said, it's actually a good practice to keep backward compatibility in same major version.

Is it time to release a new major? I don't think so, maybe we can wait PS 8.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants