Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command to desactive / active all or a specific override #40

Open
ghost opened this issue Feb 6, 2020 · 3 comments
Open

Add command to desactive / active all or a specific override #40

ghost opened this issue Feb 6, 2020 · 3 comments
Labels
feature a new feature to implement help wanted Extra attention is needed
Projects

Comments

@ghost
Copy link

ghost commented Feb 6, 2020

Add a command to disable or enable all overrides.

Like here :

https://github.com/nenes25/prestashop_console/pull/3/files

To go deep I also wanted to add the possibility to desactive or active a specific override by playing on the class_index.php and file extension in the override folder.

I don't know if it's the best way

@ghost ghost changed the title Add command to desactive / active all or specific an override Add command to desactive / active all or a specific override Feb 6, 2020
@SebSept
Copy link
Contributor

SebSept commented Feb 8, 2020

A command to enable/disable overrides is a great idea 👍

To go deep I also wanted to add the possibility to desactive or active a specific override by playing on the class_index.php and file extension in the override folder.

To modify a generated file does not sound as a good idea. 😨
Nothing prevents that file to be rewritten, so changes are lost.

Dealing with classical override mechanisms seems better.

@nenes25 nenes25 added this to Backlog in 1.4 Feb 12, 2020
@SebSept SebSept added the feature a new feature to implement label Nov 24, 2020
@SebSept SebSept added the help wanted Extra attention is needed label Dec 22, 2020
@ghost ghost moved this from Backlog to To do in 1.4 May 27, 2021
@ghost ghost moved this from To do to In progress in 1.4 May 27, 2021
@ghost ghost moved this from In progress to To do in 1.4 Oct 4, 2021
@ghost ghost added this to Backlog in 1.5 Oct 13, 2021
@tom-combet
Copy link
Contributor

tom-combet commented Sep 21, 2022

We could just remove class_index.php after disabling/enabling override?

@SebSept
Copy link
Contributor

SebSept commented Nov 4, 2022

maybe.

Are someone really interested by this command ?
@okom3pom , still interested by this feature ?
Should we keep this issue open ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a new feature to implement help wanted Extra attention is needed
Projects
1.5
Backlog
1.4
  
To do
Development

No branches or pull requests

2 participants