Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add share menu fallback #170

Closed
Tracked by #52
, #152
...
philipbrembeck opened this issue Feb 16, 2023 · 0 comments
Closed
Tracked by #52
, #152
...

Add share menu fallback #170

philipbrembeck opened this issue Feb 16, 2023 · 0 comments
Assignees
@philipbrembeck
Labels
enhancement New feature or request React

Comments

@philipbrembeck
Copy link
Collaborator

Proposed changes

As in the old VeganCheck app based on PHP, there should also be a fallback for the share button if navigator.share is undefined.

On v2.x-PHP you can find the old share modal beginning from main.php:72:
https://github.com/JokeNetwork/vegancheck.me/blob/0ed4d268aee694480a81dd8a9a2a1a433ed3119b/main.php#L72-L103

and the correspondent Javascript can be found beginning from app.js:309:
https://github.com/JokeNetwork/vegancheck.me/blob/0ed4d268aee694480a81dd8a9a2a1a433ed3119b/js/app.js#L310-L359

Related issues

This is related to #154.
@philipbrembeck philipbrembeck added enhancement New feature or request React labels Feb 16, 2023
@philipbrembeck philipbrembeck self-assigned this Feb 16, 2023
This was referenced Feb 16, 2023
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philipbrembeck philipbrembeck

Labels
enhancement New feature or request React
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@philipbrembeck