Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for $missinginfo #70

Closed
Tracked by #52
gitgauner opened this issue Jan 3, 2022 · 1 comment
Closed
Tracked by #52

Improvements for $missinginfo #70

gitgauner opened this issue Jan 3, 2022 · 1 comment
Assignees
Labels
documentation Improvements or additions to documentation low priority Fix when there is time v1.5

Comments

@gitgauner
Copy link
Contributor

Comment & make comprehensible how $missinginfo comes about and document what exactly has to be changed in OFF/OBF to make this string disappear and switch to a valid result page.

else {
echo '<div class="animated fadeIn">
  <div class="resultborder">
    <span>'.$missinginfo.'</span>
    <p class="missing">
      '.$addinfo.' <a href="https://world.openfoodfacts.org/cgi/product.pl?code='.$barcode.'">'.$editonoff.'</a>.
    </p></span>
    '.$openissue.'
  </div>
</div>'; }

(There's a redundant </span>-tag!)

Also consider to display the name of the product if available.

@gitgauner gitgauner added documentation Improvements or additions to documentation low priority Fix when there is time v1.5 labels Jan 3, 2022
@gitgauner gitgauner added this to the v1.5 milestone Jan 3, 2022
@gitgauner gitgauner mentioned this issue Jan 3, 2022
31 tasks
@philipbrembeck
Copy link
Collaborator

While commenting on this, I've found out that $missinginfo actually is wrong, we just don't get any information about the Vegan status/palm-oil status, because the array is not set.
The name and the nutriscore are both available. Will open a new issue with this info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation low priority Fix when there is time v1.5
Projects
None yet
Development

No branches or pull requests

2 participants