Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import .ospath #920

Merged
merged 1 commit into from
Apr 21, 2024
Merged

Import .ospath #920

merged 1 commit into from
Apr 21, 2024

Conversation

mkmer
Copy link
Contributor

@mkmer mkmer commented Apr 21, 2024

Description:

Looks like we need to import .ospath with >0.8.0 aiofiles. The HA folks with lower versions will need to figure out what custom integration they have that forced 0.6.0 to install.
I closed the HA update to 0.22.7 as it will break for all other "normal" users.

Related issue (if applicable): fixes #919

Checklist:

  • Local tests with tox run successfully PR cannot be meged unless tests pass
  • Changes tested locally to ensure platform still works as intended
  • Tests added to verify new code works

Copy link

codecov bot commented Apr 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.7%. Comparing base (560131b) to head (28e96d2).
Report is 12 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #920   +/-   ##
=====================================
  Coverage   99.7%   99.7%           
=====================================
  Files          8       8           
  Lines       1486    1487    +1     
=====================================
+ Hits        1483    1484    +1     
  Misses         3       3           
Flag Coverage Δ
unittests 99.7% <100.0%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fronzbot fronzbot merged commit 70e03a7 into fronzbot:dev Apr 21, 2024
8 checks passed
@mkmer mkmer deleted the Need-to-import-ospath branch April 21, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_parse_downloaded_items throws AttributeError: module 'aiofiles' has no attribute 'ospath'
2 participants