Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faster! #40

Open
1 task
frosklis opened this issue Feb 24, 2021 · 1 comment
Open
1 task

Faster! #40

frosklis opened this issue Feb 24, 2021 · 1 comment
Assignees
@frosklis
Labels
enhancement New feature or request

Comments

@frosklis
Copy link
Collaborator

frosklis commented Feb 24, 2021 •
edited
Loading

Although with its current speed dinero is already usable, it is still significantly slower than ledger (hledger cannot parse my personal file, so did not compare).

My personal ledger contains 25K+ postings.

> time dinero accounts > /dev/null
dinero accounts > /dev/null  7,86s user 0,16s system 99% cpu 8,040 total

> time ledger accounts > /dev/null
ledger accounts > /dev/null  2,76s user 0,29s system 99% cpu 3,068 total

About 3 times slower.

  • build some kind of benchmark to be able to keep track of this
@frosklis frosklis added the enhancement New feature or request label Feb 24, 2021
frosklis added a commit that referenced this issue Feb 24, 2021
@frosklis
add benchmark for #40
952d2c7
frosklis added a commit that referenced this issue Feb 24, 2021
@frosklis
little optimisation based on the neutral value for and and ors #40
525c742
frosklis added a commit that referenced this issue Feb 25, 2021
@frosklis
Do not match automated transactions more than once
15cccf3 
Imitate the ```ledger``` behaviour: once a transaction is matched by an
automated transaction, stop looking for more matches.

This helps with the behaviour of my personal ledger #1 and also makes
things slightly faster #40.
frosklis added a commit that referenced this issue Feb 27, 2021
@frosklis
Add cache for regex match in lists #40
88bdc14
frosklis added a commit that referenced this issue Feb 27, 2021
@frosklis
Made it twice as fast #40
8d47e91 
Still not as fast as ``ledger``` though.

- Little impact: cache the payee regexes
- Big impact: parse the abstract syntax trees only once per expression.
frosklis added a commit that referenced this issue Feb 27, 2021
@frosklis
more caching #41, #40
1f17a5c
frosklis added a commit that referenced this issue Feb 28, 2021
@frosklis
modify benchmarking scripts (they still depend on my personal ledger …
a92bd7e 
…file) #40.
frosklis added a commit that referenced this issue Mar 8, 2021
@frosklis
thanks @mbrubeck for helping to find this, #41, #40
7a90ebc
frosklis added a commit that referenced this issue Mar 8, 2021
@frosklis
Merge pull request #56 from frosklis/feature/41_regexes
e78462e 
thanks @mbrubeck for helping to find this, #41, #40
@frosklis frosklis self-assigned this Mar 20, 2021
@frosklis
Copy link
Collaborator Author

One place where I see improvement potential (as a user) is when using the --exchange option in a register report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frosklis frosklis

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@frosklis