Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitt receivingState into RSSI & repeater count #37

Closed
dominikkv opened this issue Dec 20, 2018 · 4 comments · Fixed by #56
Closed

Splitt receivingState into RSSI & repeater count #37

dominikkv opened this issue Dec 20, 2018 · 4 comments · Fixed by #56

Comments

@dominikkv
Copy link
Collaborator

I think of splitting the channel "receivingState" into its parts RSSI & repeater count to log these values in database, to see anomalies. I think the best would be to remove "receivingState", because one can build this string on his own.

I'm open for discussion :-)

@fruggy83
Copy link
Owner

That is a good idee. Another interesting information could be the last update timestamp. What do you thing should we add this too or do we have other easy options to get this information?

@dominikkv
Copy link
Collaborator Author

I have also thought about the last update timestamp in the context of this issue :-D This is definately an important maintenance factor. But I think we have to think about these points:

  • Let's call it "last received", because updates can be performed through OH. We are intrested in the time when we received a message, not when the user changed an item state in OH.
  • This channel would represent the last time OH received a telegram from the thing, so the scope is the thing, not an item.
  • Let's keep in mind that this can be also done by the persistence layer or a rule.

Never the less, to be more user friendly, I think we should implement it.
Another question, I'd like to implement these channels as basic channels which every EnOcean Thing has, so we do not have to declare those channels on each individual thing type. That would lead to a situation where even things only used to send messages would have those channels. Is that OK?

PS: I have opened a discussion about meta channels in the forums:
https://community.openhab.org/t/metadata-for-things/62037

@dominikkv
Copy link
Collaborator Author

So the first implementation of the three channels is in branch 37-metadata. I haven't deleted the old receivingState channel still exists, because I'd like to wait until the other branches are merged into master to avoid conflicts. The plan is to remove the channel from all EEPTypes.

@dominikkv
Copy link
Collaborator Author

Old channel deleted & PR created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants