Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USB Auto discovery detects every FTDI device as an USB300 gateway #38

Open
fruggy83 opened this issue Dec 23, 2018 · 11 comments
Open

USB Auto discovery detects every FTDI device as an USB300 gateway #38

fruggy83 opened this issue Dec 23, 2018 · 11 comments

Comments

@fruggy83
Copy link
Owner

The USB dicovery just checks the vendor and product id => each FTDI device is detected as an USB300 gateway. The manufacturer should be added to this check.

@fruggy83
Copy link
Owner Author

I am working on this.

@fruggy83
Copy link
Owner Author

pushed directly to master to ease the testing

@fruggy83
Copy link
Owner Author

@bodiroga, @dominikkv could you do me favor and test this commit with your USB300 devices. I already tested it with a FTDI serial programmer. This device was not recognized as an USB300 gateway. However my EnOcean stick got recognized as expected.

@dominikkv
Copy link
Collaborator

I'll test it tomorrow.

@dominikkv
Copy link
Collaborator

Auto discovery does not work with rfc2217, right? I'll have to change my docker config to expose USB to OpenHAB again, that's why I haven't tested yet. Plans are to do it on Thursday :-)

@dominikkv
Copy link
Collaborator

Test was not successful. Manufacturer name and product name do not match! Here is my UsbSerialDeviceInformation:

01:02:35.208 [DEBUG] [.EnOceanUsbSerialDiscoveryParticipant] - New device found: UsbSerialDeviceInformation [vendorId=0x0403, productId=0x6001, serialNumber=xxxxxxxx, manufacturer=FTDI, product=FT232R USB UART, interfaceNumber=0x00, interfaceDescription=FT232R USB UART, serialPort=/dev/ttyUSB0]

@fruggy83
Copy link
Owner Author

fruggy83 commented Jan 6, 2019

Hi @dominikkv,

thanks a lot for your test. What kind of USB dongle do you own. Really interesting that your dongles does not have EnOcean as manufacturer.

@dominikkv
Copy link
Collaborator

https://www.amazon.de/d/B01DRO7B2U
Maybe not the official stick :-D

@fruggy83
Copy link
Owner Author

fruggy83 commented Jan 8, 2019

Hi @dominikkv,

as your stick just provides generic FTDI information and nothing specific about EnOcean, I would like to stick with the current solution. Drawback: Auto discovery of these sticks is not working.

@bodiroga
Copy link
Contributor

Hi @fruggy83!

Excuse me for being so late, I don't know if this issue is resolved or I can do anything to fix it. And sorry for not checking the manufacturer ID in the USBDiscovery part of the code, my check was too generic 😢

Thanks for your work!

@dominikkv
Copy link
Collaborator

Drawback: Auto discovery of these sticks is not working.

That's fine, but then we should mention it in the docu with a guide to add them manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants