Force double quotes #274
Merged
Force double quotes #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vast I believe we should mention this thing in changelog with the link to pull request. |
|
@timurvafin, thanks, done in 9132965 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using double quotes in Ruby and CoffeeScript will reduce the number of changes we have to make when a string transitions into something that needs interpolation or escaped characters:
"Isn't this nice?""It is #{nice}""[data-behavour='exceprt']"This will also make our code consistent: all strings will now have double quotes regardless of their content.
In order to be completely consistent and not to have different conventions we should also force the same rule in SCSS.