Use ENV for configure exclusively #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # ROLLBAR_KEY=your_key_here | ||
|
|
||
| # enable basic auth to close the app from unauthorized viewers: | ||
| # We send devise email using this "from" address | ||
| MAILER_SENDER=noreply@example.com |
There was a problem hiding this comment.
maybe 'address' is better than 'sender' here
|
🆗 except tests |
|
Looks 👍 |
|
🆗 |
* Remove `app_config` shortcut * Add `HOST` variable * Add `MAILER_SENDER` variable We should configure application using only ENV variables. No need to add additional layer of complexity with `app_config`.
timurvafin
added a commit
that referenced
this pull request
Nov 6, 2015
Use ENV for configure exclusively
timurvafin
added a commit
that referenced
this pull request
Nov 27, 2015
- Introduce [Draper](https://github.com/drapergem/draper) for presenting models into views - Move Rack::MiniProfiler authorization to initializers - Add ability to configure SMTP Mailer options not only with SendGrid via `config/initializers/mailer.rb` - [Remove `app_config`](#342) shortcut and use `ENV` exclusively - Turning on Partial Double Verification for Rspec - Replace [rails_12factor](https://github.com/heroku/rails_12factor) with [rails_stdout_logging](https://github.com/heroku/rails_stdout_logging) - Update [foundation-rails gem](https://github.com/zurb/foundation-rails) - Update [rollbar gem](https://github.com/rollbar/rollbar-gem) - Add gem [rack-mini-profiler](https://github.com/MiniProfiler/rack-mini-profiler) for displaying speed badge for every html page. - Add configuration for [NewRelic](https://devcenter.heroku.com/articles/newrelic) Heroku-addon - Implement the dynamic database name
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
app_configshortcutHOSTvariableMAILER_SENDER_ADDRESSvariableWe should configure application using only ENV variables.
No need to add additional layer of complexity with
app_config.