Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OnWheel and OnMouseWheel should have type WheelEventArgs #323

Closed
ZeroBomb opened this issue Aug 30, 2023 · 0 comments · Fixed by #324
Closed

OnWheel and OnMouseWheel should have type WheelEventArgs #323

ZeroBomb opened this issue Aug 30, 2023 · 0 comments · Fixed by #324
Labels
enhancement New feature or request

Comments

@ZeroBomb
Copy link

ZeroBomb commented Aug 30, 2023 •
edited
Loading

In these two locations:

https://github.com/search?q=repo%3Afsbolero%2FBolero%20OnWheel&type=code

OnWheel and OnMouseWheel are defined to have MouseEventArgs, but I believe they should have the type WheelEventArgs.

WheelEventArgs inherits from MouseEventArgs, but includes the additional properties DeltaMode, DeltaX, DeltaY and DeltaZ that describe the scroll distance.

Currently it is possible to work around this by downcasting the OnWheel events to WheelEventArgs.
@Tarmil Tarmil added the enhancement New feature or request label Aug 31, 2023
@Tarmil Tarmil mentioned this issue Aug 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add WheelEventArgs and ErrorEventArgs fsbolero/Bolero
2 participants
@Tarmil @ZeroBomb