Simple completion in type hints/definitions #908
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a simple, flawed, but nevertheless useful, filter to completion results when the location is inside a
SynType
. This works in record fields and type hints. I haven't checked exhaustively, but I trust the AST walker and unless I've misunderstood we shouldn't find general expressions inside.I tried to use this for Type parameters but it didn't work. I'm not very familiar with FCS's internals but I suspect it only uses getAllSymbols as a fallback and so doesn't need it in type pars. I imagine this means this feature will stop working with some future update of FCS.
This feature still suffers from the problem of the first few characters not triggering completion correctly.
Completion in a record field's type:
Completion in a normal expression:
Completion in a type hint:
Q: Are there any other completion items that should be returned? Keywords?