Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SRTP] Allow overrides in the modern SRTP syntax #1318

Open
5 of 6 tasks
xperiandri opened this issue Sep 15, 2023 · 2 comments
Open
5 of 6 tasks

[SRTP] Allow overrides in the modern SRTP syntax #1318

xperiandri opened this issue Sep 15, 2023 · 2 comments

Comments

@xperiandri
Copy link

xperiandri commented Sep 15, 2023

I propose we allow overrides in modern SRTP syntax as the code below does not work

Only the last Slice: int -> 'c method override condition is resolved but no one before the last

open System.Runtime.CompilerServices

[<Extension>]
type SliceExtensions =
    [<Extension>]
    static member inline GetSlice<'c
            when 'c : (member Slice: int * int -> 'c)
            and  'c : (member Slice: int -> 'c)
            and  'c : (member Length: int)>
        (source: 'c, from: int option, ``to``: int option) =

        match from, ``to`` with
        | Some from, Some ``to`` -> source.Slice(from, ``to`` + 1 - from)
        | Some from, None -> source.Slice(from)
        | None, Some ``to`` -> source.Slice(0, ``to`` + 1)
        | None, None -> source.Slice(0, 1)

open System.Collections.Immutable

let arr = seq { 0; 1; 2; 3; 4 } |> ImmutableArray.CreateRange
arr[..2]

If you swap

            when 'c : (member Slice: int * int -> 'c)
            and  'c : (member Slice: int -> 'c)

as

            when 'c : (member Slice: int -> 'c)
            and  'c : (member Slice: int * int -> 'c)

the compiler will use the the second one again but not both

The existing way of approaching this problem in F# is to use old SRTP syntax

Pros and Cons

The advantages of making this adjustment to F# are code amount reduction

The disadvantages of making this adjustment to F# are not exist

Extra information

Estimated cost (XS, S, M, L, XL, XXL): S

Related suggestions:

Affidavit (please submit!)

Please tick these items by placing a cross in the box:

  • This is not a question (e.g. like one you might ask on StackOverflow) and I have searched StackOverflow for discussions of this issue
  • This is a language change and not purely a tooling change (e.g. compiler bug, editor support, warning/error messages, new warning, non-breaking optimisation) belonging to the compiler and tooling repository
  • This is not something which has obviously "already been decided" in previous versions of F#. If you're questioning a fundamental design decision that has obviously already been taken (e.g. "Make F# untyped") then please don't submit it
  • I have searched both open and closed suggestions on this site and believe this is not a duplicate

Please tick all that apply:

  • This is not a breaking change to the F# language design
  • I or my company would be willing to help implement and/or test this

For Readers

If you would like to see this issue implemented, please click the 👍 emoji on this issue. These counts are used to generally order the suggestions by engagement.

@xperiandri
Copy link
Author

xperiandri commented Sep 15, 2023

Without SRTP overrides it works

open System.Runtime.CompilerServices

[<Extension>]
type SliceExtensions =

    [<Extension>]
    static member inline GetSlice<'c
            when 'c : (member Slice: int * int -> 'c)
            and  'c : (member Length: int)>
        (source: 'c, from: int option, ``to``: int option) =

        let from = from |> Option.defaultValue 0
        let ``to`` = ``to`` |> Option.defaultValue (source.Length - 1)
        source.Slice(from, ``to`` + 1 - from)

open System.Collections.Immutable

let arr = seq { 0; 1; 2; 3; 4 } |> ImmutableArray.CreateRange
arr[..2]

@nodakai
Copy link

nodakai commented Dec 15, 2023

It seems you're referring to "overloads"? https://stackoverflow.com/questions/673721/overloading-and-overriding

I ended up posting a duplicate as issue #1342, as this didn't come up in my search.

Also, based on my example, it appears this issue arises with or without the new SRTP syntax.

I recommend revising the title for better accuracy, and I can then close mine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants