Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ParsedHashDirectives to have argument types other than strings #1364

Closed
KevinRansom opened this issue May 24, 2024 · 2 comments
Closed

Comments

@KevinRansom
Copy link

ParsedHashDirectives can currently only have string arguments.

This means that the syntax for HashDirectives is constrained to having quoted string arguments.

This makes some of the Hash directive syntax a little clunky.

#time "on"
(* Do lots of stuff here *)
#time "off"

probably would be nicer and perhaps easier to get right first time like this

#time on
(* Do lots of stuff here *)
#time off

Similarly no warn requires numeric error numbers to be integers:

#nowarn "1234" "1235" "99"

Is probably better expressed as:

#nowarn 1234 1235 99
@KevinRansom KevinRansom changed the title Allow #ParsedHashDirectives to have argument types oter than strings Allow #ParsedHashDirectives to have argument types other than strings May 24, 2024
@KevinRansom KevinRansom changed the title Allow #ParsedHashDirectives to have argument types other than strings Allow ParsedHashDirectives to have argument types other than strings May 24, 2024
@abelbraaksma
Copy link
Member

abelbraaksma commented May 24, 2024

Hi Kevin, I propose we reopen this in favor of the referenced issue and give this an (albeit trivial) treatment with approval process, RFC etc.

@abelbraaksma
Copy link
Member

Here we go. We can keep this closed, but we can continue here (#1368). I hope I captured your intend properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants