Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preprocessor Directives: #elif missing #1370

Open
5 of 6 tasks
Thorium opened this issue Jun 6, 2024 · 2 comments
Open
5 of 6 tasks

Preprocessor Directives: #elif missing #1370

Thorium opened this issue Jun 6, 2024 · 2 comments

Comments

@Thorium
Copy link

Thorium commented Jun 6, 2024

I propose we add #elif to the preprocessor grammar as part of the #if .. #else .. #endif block.

The existing way of approaching this problem in F# is: Nesting another #if under #else.

Pros and Cons

The advantages of making this adjustment to F# are: alignment with C# and simpler syntax.

The disadvantages of making this adjustment to F# are: none (well, it's work to implement).

Motivation

F# seems to have #elif preprocessor directive / pragma missing:
https://learn.microsoft.com/en-us/dotnet/fsharp/language-reference/compiler-directives#preprocessor-directives

C# has it:
https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/preprocessor-directives#conditional-compilation

I know it's not good practice to use lot of these, I'm not trying to do a templating engine, I would just like to do a simple switch like this:

[<Literal>]
let myPath =
#if WIN64
  "/library/x64/runtime.dll"
#elif WIN86
  "/library/x86/runtime.dll"
#elif MAC
  "/library/iOS/runtime-osx.dll"
#else
  "/library/unix/runtime.dll"
#endif

The current workaround:

[<Literal>]
let myPath =
#if WIN64
  "/library/x64/runtime.dll"
#endif 
#if WIN86
  "/library/x86/runtime.dll"
#endif 
#if MAC
  "/library/iOS/runtime-osx.dll"
#endif 
#if !WIN64 && !WIN86 && !MAC
  "/library/unix/runtime.dll"
#endif

Extra information

Estimated cost (XS, S, M, L, XL, XXL): S

Related suggestions: #273

Affidavit (please submit!)

Please tick these items by placing a cross in the box:

  • This is not a question (e.g. like one you might ask on StackOverflow) and I have searched StackOverflow for discussions of this issue
  • This is a language change and not purely a tooling change (e.g. compiler bug, editor support, warning/error messages, new warning, non-breaking optimisation) belonging to the compiler and tooling repository
  • This is not something which has obviously "already been decided" in previous versions of F#. If you're questioning a fundamental design decision that has obviously already been taken (e.g. "Make F# untyped") then please don't submit it
  • I have searched both open and closed suggestions on this site and believe this is not a duplicate (Allow extended #if grammar #273 is similar, but not a duplicate)

Please tick all that apply:

  • This is not a breaking change to the F# language design
  • I or my company would be willing to help implement and/or test this

For Readers

If you would like to see this issue implemented, please click the 👍 emoji on this issue. These counts are used to generally order the suggestions by engagement.

Moved from: dotnet/fsharp#17282

@abelbraaksma
Copy link
Member

(partial copy of relevant bits of my comment)

I think this is a reasonable suggestion.

It appears to have been suggested in the F# 4 days, but not the whole proposal has made it back then: #273


Note that #if can be nested, so your code example may be easier if turned into this:

let myPath =
#if WIN64
    "/library/x64/runtime.dll"
#else
    #if WIN86
        "/library/x86/runtime.dll"
    #else
        #if MAC
            "/library/iOS/runtime-osx.dll"
        #else
            "/library/unix/runtime.dll"
        #endif
    #endif
#endif

(I mean, it would be easier to read with your suggestion, but at least you won't need the complex boolean expressions)

@abelbraaksma
Copy link
Member

(updated the issue to match the issue template, which got lost in moving the issue over, feel free to edit further, @Thorium)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants