-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Msbuild max cpu #2772
Msbuild max cpu #2772
Conversation
8290734
to
2824c7d
Compare
2824c7d
to
6867806
Compare
6867806
to
50102fc
Compare
I wonder why was it disabled before 🙂 |
Could you add the line about this to the release notes? |
My guess is it's a holdover from the mono/xbuild days. |
Looks like the changes to the flags cause some unit test failures:
Maybe needs changing around
|
50102fc
to
6175995
Compare
Will you fix the conflict? |
Probably not for a while. Won’t be near a computer for a few days. |
I can't update the PR, but I did try pushing a rebased version into https://github.com/Numpsy/FAKE/tree/msbuild-max-cpu as a test (the conflict is just in the release notes again). I also noticed that the release note change here says |
@TheAngryByrd have you gotten back? |
I've had a go at fixing the merge issues in #2789 in case getting it up to date is helpful |
Description
Allows properties like MaxCpuCount to be used on unix.
Mostly checking CI to see if it breaks something.
If available, link to an existing issue this PR fixes. For example:
TODO
Feel free to open the PR and ask for help
New (API-)documentation for new features exist (Note: API-docs are enough, additional docs are in
help/markdown
)unit or integration test exists (or short reasoning why it doesn't make sense)
boy scout rule: "leave the code behind in a better state than you found it" (fix warnings, obsolete members or code-style in the places you worked in)
(if new module) the module has been linked from the "side navigation" menu, edit
docs/data.json
.(if new module) the module is in the correct namespace.
(if new module) the module is added to Fake.sln (
dotnet sln Fake.sln add src/app/Fake.*/Fake.*.fsproj
)Fake API guideline is honored