Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Xamarin.Forms 4.6 #726

Merged
merged 3 commits into from
May 4, 2020

Conversation

TimLariviere
Copy link
Member

Xamarin.Forms 4.6 has been released yesterday.
It contains 2 new controls: Expander and RadioButton as well as support for AppTheme (Light and Dark).
I added samples for those 3 in the AllControls sample.

@TimLariviere
Copy link
Member Author

/azp run full build

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

…UseCases/AppTheming.fs

Co-authored-by: Russell Dillin <rastreus@gmail.com>
@TimLariviere
Copy link
Member Author

TimLariviere commented May 2, 2020

Not sure how AppTheme is supposed to work.
Tested it on both iOS and Android, and it doesn't work.

iOS never triggers Application.Current.RequestedThemeChanged when the phone theme change.
Android recreates the activity hosting XF/Fabulous, thus resetting the state of the app to 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants