Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FSharp.Data Tests and Documentation to work with JSonValue #108

Open
jkone27 opened this issue Apr 30, 2021 · 1 comment
Open

Add FSharp.Data Tests and Documentation to work with JSonValue #108

jkone27 opened this issue Apr 30, 2021 · 1 comment

Comments

@jkone27
Copy link

jkone27 commented Apr 30, 2021

Would be very useful to have unit tests (i see the project is empty) and/or documentation to work with FSharp.Data.JsonValue lenses

@wallymathieu
Copy link
Member

wallymathieu commented Apr 30, 2021

The tests that execute are the same as can be found for other implementations, there are some ifdefs in the source:
Note the references in fsproj here:
https://github.com/fsprojects/Fleece/blob/v0.9.0/test/Tests.FSharpData/Tests.FSharpData.fsproj#L9-L10

The ifdefs are here:
https://github.com/fsprojects/Fleece/blob/v0.9.0/test/Tests/Lenses.fs#L10-L15

Having additional tests and documentation would be neat though 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants