Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py3.6 >= support #445

Closed
isidentical opened this issue Mar 18, 2021 · 5 comments · Fixed by #462
Closed

py3.6 >= support #445

isidentical opened this issue Mar 18, 2021 · 5 comments · Fixed by #462

Comments

@isidentical
Copy link
Member

I see that 3.6 support dropped in this commit though it is not clear about reasoning. I would assume it is because it's EOL coming in 9 months, though 3.6 might still be one of the most used versions. Would it make sense to bring the support back?

@martindurant
Copy link
Member

The happened after the confluence of a couple of things

  • a general move in the pydata ecosystem (like pandas, dask and many more)
  • a specific async issue in fsspec that I could not resolve for py 3.6

The latter point might have been avoided in fsspec/filesystem_spec#572 , but I'd like to avoid possible differences in asyncio API for py36.

3.6 might still be one of the most used versions

This maybe true, but those on py36 probably don't install the latest releases of packages like s3fs.

@isidentical
Copy link
Member Author

isidentical commented Mar 18, 2021

a general move in the pydata ecosystem (like pandas, dask and many more)

When would you think that filesystem-spec will drop the 3.6 support though?

@martindurant
Copy link
Member

That is up for debate. If we are to have it, then the CI should be made to run on 3.6. I don't know if the async thing will work or not. Most implementations don't need it, but HTTP, abfs, s3fs and gcsfs do.

@isidentical
Copy link
Member Author

That is up for debate. If we are to have it, then the CI should be made to run on 3.6. I don't know if the async thing will work or not. Most implementations don't need it, but HTTP, abfs, s3fs and gcsfs do.

I can try to send a pull request that adds workflows, though I guess we should move the discussion over there?

@martindurant
Copy link
Member

Sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants