Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obsolete property in Challenge resource #99

Closed
JeffreyVerbeek opened this issue May 3, 2018 · 3 comments · Fixed by #102
Closed

Obsolete property in Challenge resource #99

JeffreyVerbeek opened this issue May 3, 2018 · 3 comments · Fixed by #102

Comments

@JeffreyVerbeek
Copy link
Contributor

When using IChallengeContext.Resource() the response is a Challenge object with a status. If the status comes back invalid there should be an error object. The current IList<object> Errors in the code is always null becouse the property has been replaced since draft 10. It is now a single error with subproblems. It can be fould in section-8

At the moment I am not able to get the reason why validation vailed.
Is this something you want to fix yourself or should I create a Pull request?

@fszlin
Copy link
Owner

fszlin commented May 4, 2018

Hi @JeffreyVerbeek , thanks for the investigation, and PR would be nice. 👍

@JeffreyVerbeek
Copy link
Contributor Author

This was actually an easy fix. But I did find something else.
You are expecting a string KeyAuthorization which I did not find in the spec.
The DateTimeOffset? Validated is not used for some reason. The spec says this property should be used if the validation is valid, but Let's Encrypt does not send it.
Let's Encrypt does send an object validationRecord which is not in the spec. Maybe this is something to look into?!

@fszlin
Copy link
Owner

fszlin commented May 4, 2018

Thanks @JeffreyVerbeek

  • keyAuthorization is in draft-09, I think we can mark it obsoleted now.
  • Validated is in draft-12, so let's keep it.
  • LE has always sending validationRecord in challenges, if it's useful for you, feel free to create new issue/PR for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants