From 795118475a59a36c3194afe47cb99fbe9aa6b4e9 Mon Sep 17 00:00:00 2001 From: Bryant Eisenbach Date: Sun, 28 Jun 2020 13:51:19 -0400 Subject: [PATCH] tests: Added xfail to complex abi decoding test for struct NOTE: This works in reality (see https://github.com/ethereum/web3.py/issues/1634#issuecomment-650797252) however our test suite currently can't handle it because of a bug in Web3.py --- tests/parser/globals/test_getters.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/parser/globals/test_getters.py b/tests/parser/globals/test_getters.py index 7a9e76c8bd7..281ef6d92aa 100644 --- a/tests/parser/globals/test_getters.py +++ b/tests/parser/globals/test_getters.py @@ -1,3 +1,5 @@ +import pytest + def test_state_accessor(get_contract_with_gas_estimation_for_constants): state_accessor = """ y: HashMap[int128, int128] @@ -16,7 +18,9 @@ def foo() -> int128: c.oo(transact={}) assert c.foo() == 5 - +# TODO: Either wait for this, or refactor test suite to use Brownie +# (which doesn't suffer from this issue) +@pytest.mark.xfail(reason="https://github.com/ethereum/web3.py/issues/1634#issuecomment-650797252") def test_getter_code(get_contract_with_gas_estimation_for_constants): getter_code = """ struct W: