Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Support type hinting with standard collections #543

Closed
goodwanghan opened this issue Jun 13, 2024 · 0 comments · Fixed by #542
Closed

[FEATURE] Support type hinting with standard collections #543

goodwanghan opened this issue Jun 13, 2024 · 0 comments · Fixed by #542
Labels
core feature enhancement New feature or request
Milestone
0.9.1

Comments

@goodwanghan
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
From Python 3.9+, standard collections such as list[list[str]] can be used as type annotations. Fugue doesn't support them.

Describe the solution you'd like
The main change is in triad: fugue-project/triad#130
In fugue, we just need to change some matcher functions and the unit tests
@goodwanghan goodwanghan added enhancement New feature or request core feature labels Jun 13, 2024
@goodwanghan goodwanghan added this to the 0.9.1 milestone Jun 13, 2024
@goodwanghan goodwanghan linked a pull request Jun 13, 2024 that will close this issue
Add more supported type annotations, fix spark connect issue #542
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core feature enhancement New feature or request
Projects
None yet
Milestone
0.9.1
Development

Successfully merging a pull request may close this issue.

Add more supported type annotations, fix spark connect issue fugue-project/fugue
1 participant
@goodwanghan