Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Fillna as builtin #95

Closed
kvnkho opened this issue Nov 2, 2020 · 0 comments · Fixed by #101 or #102
Closed

[FEATURE] Fillna as builtin #95

kvnkho opened this issue Nov 2, 2020 · 0 comments · Fixed by #101 or #102
Labels
core feature enhancement New feature or request Fugue SQL programming interface
Milestone
0.4.6

Comments

@kvnkho
Copy link
Collaborator

kvnkho commented Nov 2, 2020 •
edited
Loading

Is your feature request related to a problem? Please describe.
We should include a fillna method in the execution engine.

Describe the solution you'd like
It just needs to be simple like the Spark implementation. No need for forward fill and backfill.

Additional context
It will have a very similar implementation to the existing dropna method in the execution engine.
@goodwanghan goodwanghan added this to the 0.4.5 milestone Nov 2, 2020
@goodwanghan goodwanghan modified the milestones: 0.4.5, 0.4.6 Nov 6, 2020
@kvnkho kvnkho linked a pull request Nov 8, 2020 that will close this issue
Interface for fillna. SQL portion will be separate. #101
Merged
@goodwanghan goodwanghan linked a pull request Nov 8, 2020 that will close this issue
Fugue SQL portion of fillna #102
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core feature enhancement New feature or request Fugue SQL programming interface
Projects
None yet
Milestone
0.4.6
Development

Successfully merging a pull request may close this issue.

Interface for fillna. SQL portion will be separate.
Fugue SQL portion of fillna
2 participants
@goodwanghan @kvnkho