github: workflows: release: Add musl build for aarch64 #724
Conversation
patrickelectric
force-pushed
the
armv7
branch
from
37745d5
to
ecec97a
Compare
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
patrickelectric
force-pushed
the
armv7
branch
from
ecec97a
to
709b83d
Compare
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
… in one Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
patrickelectric
force-pushed
the
armv7
branch
from
709b83d
to
d37620e
Compare
There was a problem hiding this comment.
@patrickelectric I've left a few comment but essentially I struggling to understand the intended behaviour of the changes here, shouldn't this be a simple case of adding the new targets?
If easier please feel free to ping me on discord or matrix to discuss (i'm fujiapple852 on both)
| tags: | ||
| - "[0-9]+.[0-9]+.[0-9]+" | ||
| pull_request: | ||
|
|
There was a problem hiding this comment.
@patrickelectric we only want to run the release workflow on a tag rather than on every pr. I assume you've done this to help you test? If so you'll need to do so on a fork as if we let this pr run now it would trigger an actual release which we do not want (it annoys package maintainers who are notified and start working on new package versions).
| jobs: | ||
| create-release: | ||
| name: create-release | ||
| runs-on: ubuntu-latest | ||
| if: startsWith(github.ref, 'refs/tags/') |
There was a problem hiding this comment.
This seems to undo the effect of the change above and only run the step for tags? I'm a bit confused as to what effect you're try to achieve here.
| @@ -38,18 +39,28 @@ jobs: | |||
| TARGET_DIR: ./target | |||
| RUST_BACKTRACE: 1 | |||
| strategy: | |||
| fail-fast: false | |||
There was a problem hiding this comment.
I think we want fail-fast as true here (the default I suspect?). if a release partially fails I would want to fix it and rerun it rather than allowing a subset of packages to be published.
| - name: Upload Artifact | ||
| uses: actions/upload-artifact@v3 | ||
| with: | ||
| name: trippy-${{ matrix.target }} | ||
| path: trippy-* | ||
| if-no-files-found: error |
There was a problem hiding this comment.
Why is this needed? There is already an step to upload a release archive
| os: ubuntu-22.04 | ||
| target: aarch64-unknown-linux-gnu | ||
| - build: linux-arm64 |
There was a problem hiding this comment.
This is a duplicate build name, did you want linux-aarch64-musl perhaps?
| - build: linux-armv7 | ||
| os: ubuntu-22.04 | ||
| target: armv7-unknown-linux-gnueabihf | ||
| - build: linux-armv7 |
|
Superseded by #810 |
Based on #713, github does not allow me reopen it (the branch name is the same 👀 )