Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unified closing handshake for client and server. #46

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

unified closing handshake for client and server. #46

wants to merge 3 commits into from

Conversation

petelliott
Copy link
Contributor

@petelliott
Copy link
Contributor Author

this seems to cause a protocol error when the server closes the connection

@petelliott petelliott closed this Jan 17, 2019
@petelliott
Copy link
Contributor Author

the error was in fast-websocket. I have opened a pull request that fixes it.
fukamachi/fast-websocket#3

@petelliott petelliott reopened this Jan 17, 2019
@fukamachi fukamachi self-requested a review August 9, 2019 10:54
@fukamachi fukamachi added the bug label Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fukamachi fukamachi Awaiting requested review from fukamachi

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
2 participants
@petelliott @fukamachi