Task Ref now increments nonce with every set

[AdamChlupacek]

As per comments in fs2.Task.ref the nonce should be updated with every successful set or modify, up till now for set the nonce was updated only in case of the first set, this PR addresses this issue.

Added a test that demonstrates the case in which this would be an issue. This would also affect modify of the ref in case there was a concurrent set on it.

[pchlupacek]

Please update comment to be inline with rest of fs2

[AdamChlupacek]

I will remove this one all together

[pchlupacek]

@pchiusano @mpilquist If there are no objections can we merge this?

[pchlupacek]

I think nonce is here internal implementation detail. What we really solving here is interleaving set and modify// access. I would prefer updated name with perhaps a short comment explaining what this tests verifies.

[mpilquist]

👍 Per Pavel's last comment, let's update the test name and then we can merge.

[pchiusano]

👍

On Mon, Oct 24, 2016 at 4:20 AM, Pavel Chlupacek notifications@github.com
wrote:

@pchlupacek commented on this pull request.

In core/jvm/src/test/scala/fs2/TaskSpec.scala
#749 (review)
:

@@ -0,0 +1,23 @@
+package fs2
+
+import scala.concurrent.duration._
+
+class TaskSpec extends Fs2Spec{
+

• "Task" - {
• "Ref" - {

•  "Set increments nonce" in {
  

I think nonce is here internal implementation detail. What we really
solving here is interleaving set and modify// access. I would prefer
updated name with perhaps a short comment explaining what this tests
verifies.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#749 (review),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAArQnTXB9aFfwJ0DUXeThj_veI7Kb6Wks5q3GpbgaJpZM4Kd_ix
.