Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component Request - gallery-list - 3hrs #3

Open
drewbaker opened this issue Jan 4, 2021 · 2 comments
Open

Component Request - gallery-list - 3hrs #3

drewbaker opened this issue Jan 4, 2021 · 2 comments

Comments

@drewbaker
Copy link
Member

drewbaker commented Jan 4, 2021

Component Description

This component is used on the home page to show a list of links with talent names. On hover of a name, it will show a featured image for that talent.

Design

Please also see attached screenshots for quick reference.

NOTE
On mobile please go to 1 column of names.
The designs show the image hover on "Jamie Ford".

Slots

None.

Props

props: {
    items: {
        // The list of talent. Can use mock API `directors` for these. Use the `featuredImage` for hover.
        type: Array,
        default: () => []
    }
}

Developer Tips

The trick will be getting the columns aligning correctly. Note the component should align vertically, and horizontally. The last column should align to the right edge of screen when sized similar to the design. If the list of names isn't the ideal length, the last column of names should align to the top of the previous column.

  1. --color-yellow for the font color
  2. --color-white for the font hover color
  3. Use unit-gap css var for padding on sides.
  4. Please have a max width of 1280px for the entire component.
  5. Please set min-height to unit-100vh.

Events

None.

Required components

  1. Use wp-image for the background image. Set it to mode="fullbleed" and use `position: absolute" with a height and width set to have it size correctly. Alternatively, use a regular image tag if you want, be sure to use src-set correct.
  2. Each name should be a nuxt-link.

Screenshots

Screen Shot 2021-01-04 at 1 16 32 PM

@3birdsmedia 3birdsmedia mentioned this issue Jan 26, 2021
7 tasks
@nickberens360
Copy link

@drewbaker it looks like ~/assets/svg/logo-funkhaus is missing which is causing an error when storybook is trying to build the GlobalHamburger.stories.js story. Currently I have the import in GlobalHamburger.stories.js commented out as a workaround. I know submitting a PR with changes outside the assigned component is against best practices. I noticed that in the example PR that the developer went through the history to find the image but that option also feels like it would be making a change outside of the assigned component. I figured I'd ask to see if you had a preferred way of handling situations like this? Unless this is part of the test. If so, just tell me to figure it out ;) Thanks

@drewbaker
Copy link
Member Author

@nickberens360 I removed the the missing logo from the repo just now. Good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants