Refactoring #37
Merged
Refactoring #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added inital slice plot, mesh plot
adds get_extent function
added requested_units to functions
added pep formatter
refactored code into core and utils, improved examples and CI
moving to new openmc_tally_unit_convertor package
added option for title
updated to work with openmc_tally_unit_converter 0.5.2
Patch release 0.2.3
|
The tests pass locally (within the fusion-neutronics-workflow container) I don't quite understand why the conda install of the dependencies doesn't work here. |
|
Any chance we could branch from develop and merge to develop |
Codecov Report
@@ Coverage Diff @@
## develop #37 +/- ##
=======================================
Coverage 0.00% 0.00%
=======================================
Files 3 3
Lines 136 136
=======================================
Misses 136 136
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33 by exposing all the arguments of imshow to users, granting more flexibility to users