Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppStream upstream metadata is missing #344

Open
2 of 5 tasks
SaptarshiSarkar12 opened this issue Jul 1, 2023 · 9 comments
Open
2 of 5 tasks

AppStream upstream metadata is missing #344

SaptarshiSarkar12 opened this issue Jul 1, 2023 · 9 comments
Labels
working on Work in progress on this issue

Comments

@SaptarshiSarkar12
Copy link
Contributor

I'm submitting a…

  • bug report
  • feature request
  • other

Short description of the issue/suggestion:
When the Drifty application is packaged using JavaPackager Maven plugin via GitHub Action, it shows the below error 👇

WARNING: AppStream upstream metadata is missing, please consider creating it

How can I fix it?

Do you have outputs, screenshots, demos or samples which demonstrate the problem or enhancement?
You can check the GitHub Action output to see the error.

Please tell us about your environment:

  • JavaPackager version: 1.7.2
  • OS version: ubuntu-22.04 (Ubuntu-latest for GitHub Action)
  • JDK version: 20.0.1
  • Build tool:
    • Maven
    • Gradle

Other Information
You can check the pom.xml file to see if any changes needs to be made in that.

@SaptarshiSarkar12
Copy link
Contributor Author

@fvarrui Please look into the issue.

@fvarrui
Copy link
Owner

fvarrui commented Jul 4, 2023

Hi @SaptarshiSarkar12!

I fear you can fix it ... unless you code a patch for JavaPackager and make a PR.

I'll take a look into it ASAP.

Anyway, it's showing a warning message, not an error. Have you tried to run the generated AppImage?

@fvarrui fvarrui added the feedback Waiting for feedback label Jul 4, 2023
@SaptarshiSarkar12
Copy link
Contributor Author

Hi @SaptarshiSarkar12!

I fear you can fix it ... unless you code a patch for JavaPackager and make a PR.

I'll take a look into it ASAP.

Anyway, it's showing a warning message, not an error. Have you tried to run the generated AppImage?

@fvarrui Yes, the AppImage runs pretty well.

@SaptarshiSarkar12
Copy link
Contributor Author

Thank you for giving your valuable time to resolve the issue!

@SaptarshiSarkar12
Copy link
Contributor Author

@fvarrui Please check this docs of freedesktop about metadata file.
It says to create a app_name.metadata.xml file in /usr/share/metainfo/ directory before building the AppImage. I think this file can be auto-created by JavaPackager before initiating the building of AppImages. So, it might be a good feature we should bring in this project.
@fvarrui Let me know your opinion.

@fvarrui
Copy link
Owner

fvarrui commented Jul 13, 2023

@SaptarshiSarkar12 Ok, I've just check this example and it seems that all required data is available in JP. As it's related to issue-345, and there's already a branch for this issue, changes will be made in this branch.

As far as I understand, this is not only for AppImage, but DEB and RPM too, right?

@fvarrui fvarrui added working on Work in progress on this issue and removed feedback Waiting for feedback labels Jul 13, 2023
@SaptarshiSarkar12
Copy link
Contributor Author

@SaptarshiSarkar12 Ok, I've just check this example and it seems that all required data is available in JP. As it's related to issue-345, and there's already a branch for this issue, changes will be made in this branch.

As far as I understand, this is not only for AppImage, but DEB and RPM too, right?

Ok @fvarrui, that's great!
No, there is some problems regarding DEB and might be RPM also. The problem is that the description shown by Software Install application in ubuntu (when trying to install DEB package) is not as what is provided to JavaPackager. Below are the required relevant screenshots and links :

Deb package in Software Install

Link to pom.xml : https://github.com/SaptarshiSarkar12/Drifty/blob/master/pom.xml

@fvarrui
Copy link
Owner

fvarrui commented Jul 13, 2023

No, there is some problems regarding DEB and might be RPM also. The problem is that the description shown by Software Install application in ubuntu (when trying to install DEB package) is not as what is provided to JavaPackager.

So, do you mean that metadata file has also to be provided by DEB and RPM packages?

@SaptarshiSarkar12
Copy link
Contributor Author

No, there is some problems regarding DEB and might be RPM also. The problem is that the description shown by Software Install application in ubuntu (when trying to install DEB package) is not as what is provided to JavaPackager.

So, do you mean that metadata file has also to be provided by DEB and RPM packages?

Yeah @fvarrui, it might help. Also, the application icon is not present when opening DEB (might be the same case with RPM) through Software Install application in Ubuntu 23.04.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
working on Work in progress on this issue
Projects
None yet
Development

No branches or pull requests

2 participants