Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove global Logger instance #40

Merged
merged 1 commit into from
Nov 19, 2024
Merged

refactor: remove global Logger instance #40

merged 1 commit into from
Nov 19, 2024

Conversation

fvsch
Copy link
Owner

@fvsch fvsch commented Nov 19, 2024

We can make the Logger utility class take writeable streams as inputs, instead of relying on process.stdout and process.stdin.

This helps with testing too.

@fvsch fvsch merged commit aa46177 into main Nov 19, 2024
3 checks passed
@fvsch fvsch deleted the fvsch/refactor-no-global-logger branch November 19, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fvsch