Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too much boilerplate for IndexedColorAnimation #18

Open
fweiss opened this issue Jul 19, 2024 · 0 comments
Open

Too much boilerplate for IndexedColorAnimation #18

fweiss opened this issue Jul 19, 2024 · 0 comments

Comments

@fweiss
Copy link
Owner

fweiss commented Jul 19, 2024

The process of doing #10 was slowed down considerably by the boilerplate. Some particular issues for EmojiAnimation:

  • have to declare the number of frames for pixelIndexes
  • having to qualify ColorIndex twice in .cpp
  • extra function in constructor
  • extra function in drawFrame

These are mostly due to wanting to make the code type safe:

  • good: no array out of range
  • bad: fussy compiler errors until you get it right

Some of the procedural animations, such as SpiralAnimation, are so much simpler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant