Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove src folder #9

Open
fweiss opened this issue Jul 3, 2024 · 2 comments
Open

Remove src folder #9

fweiss opened this issue Jul 3, 2024 · 2 comments

Comments

@fweiss
Copy link
Owner

fweiss commented Jul 3, 2024

There's duplicate code and it can cause confusion. It may be left over from before idf. Yeah, it depends on AdaFruit_Neopixel library.

There is a neat Cp437 utf8tocp437 which probably was for the adafruit chargen. Maybe publish that somewhere.

@fweiss
Copy link
Owner Author

fweiss commented Jul 8, 2024

The samples folder contains some .ino files, so looks like this was from early Arduino codebase. There is also mention of Adafruit Feather.

The badge folder contains some animations which may be interesting to port over to the new codebase before removing this folder.

@fweiss
Copy link
Owner Author

fweiss commented Aug 4, 2024

Proposal:

  • select any files for retention (should be just ./src)
  • note/dispose of selected files
  • tag HEAD/master with "Retained ESP8266 animation code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant