Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Check for code coverage dropping below 98% before PR is merged #403

Closed
fxamacker opened this issue May 14, 2023 · 0 comments · Fixed by #404
Closed

CI: Check for code coverage dropping below 98% before PR is merged #403

fxamacker opened this issue May 14, 2023 · 0 comments · Fixed by #404
Labels
CI CI using GitHub Actions Workflow

Comments

@fxamacker
Copy link
Owner

This check should run before PR is merged, but CI didn't show code coverage regression until after PR was merged.

@x448 Can you tweak the Github Actions workflow to resolve this? 🙏
@fxamacker fxamacker added the CI CI using GitHub Actions Workflow label May 14, 2023
@x448 x448 mentioned this issue May 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI CI using GitHub Actions Workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update ci-go-cover.yml x448/cbor
1 participant
@fxamacker