Refactor to reuse functions and improve code coverage #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes encodeFixedLengthStruct() and reuses encodeStruct() to simplify code. Previously, encodeStruct() used extra buffer to encode elements to get actual encoded element count. To avoid this overhead, encodeFixedLengthStruct() was created to encode fixed length struct (struct without any "omitempty" fields) since encoded element count is always known in this use case. With PR #519 (#519), encodeStruct() doesn't use extra buffer any more, and encodeFixedLengthStruct() isn't necessary.
x448
approved these changes
May 5, 2024
This commit removes encodedHeadLen() and modifies encodeHead() to return encoded head length to simplify code.
fxamacker
force-pushed
the
fxamacker/refactor-to-reuse-code
branch
from
af12989 to
f83a7d0
Compare
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors code to reuse functions and improve code coverage:
Remove
encodeFixedLengthStruct()and reuseencodeStruct()Previously,
encodeStruct()used extra buffer to encode elements to get actual encoded element count. To avoid this overhead,encodeFixedLengthStruct()was created to encode fixed length struct (struct without any "omitempty" fields) since encoded element count is always known in this use case.Since @benluddy's PR Encode structs directly to output buffer. #519,
encodeStruct()doesn't use extra buffer any more, andencodeFixedLengthStruct()isn't necessary. Thanks Ben! 👍Combine
encodeHead()andencodedHeadLen()to avoid these two functions out of sync.encodeHead()is modified to return encoded head length so caller doesn't need to callencodedHeadLen()separately.