Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links in Markdown/Rich Text lists breaks formatting #2911

Closed
alexrudd opened this issue Apr 11, 2022 · 5 comments
Closed

Links in Markdown/Rich Text lists breaks formatting #2911

alexrudd opened this issue Apr 11, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@alexrudd
Copy link

Describe the bug:

Including a link at the end of an element in a list breaks the formatting when rendered:

* [List item one](https://item1.com)
* [List item two](https://item2.com)

To Reproduce:

Steps to reproduce the behaviour:

  1. Create an application that uses the NewRichTextFromMarkdown widget
  2. Pass in the markdown from above
  3. Run the app and see the bug

Screenshots:

image

Example code:

package main

import (
	"fyne.io/fyne/v2/app"
	"fyne.io/fyne/v2/widget"
)

func main() {
	a := app.New()
	w := a.NewWindow("Hello World")

	w.SetContent(widget.NewRichTextFromMarkdown(`
# Reproduce list bug

* [List item one](https://item1.com)
* [List item two](https://item2.com)

## Workaround using fullstops

* [List item one](https://item1.com).
* [List item two](https://item2.com).

## Without links

* Item one
* Item two
`))
	w.ShowAndRun()
}

Device (please complete the following information):

  • OS: Windows
  • Version: 10.0.19043
  • Go version: 1.18.0
  • Fyne version: v2.1.4
@alexrudd alexrudd added the unverified A bug that has been reported but not verified label Apr 11, 2022
@andydotxyz andydotxyz added bug Something isn't working and removed unverified A bug that has been reported but not verified labels Jun 21, 2022
@andydotxyz andydotxyz added this to the Fixes (v2.2.x) milestone Jun 21, 2022
@matwachich
Copy link
Contributor

This is also the same thing for normal URL widget when placed in a VBox for example (the underline continues until the end)

@andydotxyz
Copy link
Member

But that isn't a break in the formatting or layout - the line literally has that much space left so the Hyperlink is asked to fill the gap - like a text like would if there was no link.

@andydotxyz
Copy link
Member

Fixed on develop and picking to 2.3.x release branch

@hdm
Copy link

hdm commented Nov 27, 2023

Quick note that this still occurs on mouseover, just not in normal state:

image

@andydotxyz
Copy link
Member

That is not the same issue. You can see above that the bullets were in the wrong place.
There is a separate PR that reduces the length of the underline, but that is not merged yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants