Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled password Entry should also disable the ActionItem (show/hide password) #3908

Closed
2 tasks done
matwachich opened this issue May 23, 2023 · 2 comments
Closed
2 tasks done
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@matwachich
Copy link
Contributor

Checklist

  • I have searched the issue tracker for open issues that relate to the same problem, before opening a new one.
  • This issue only relates to a single bug. I will open new issues for any other problems.

Describe the bug

When an Entry with .Password=true is disabled, the Action item button should also be disabled.

How to reproduce

Disable a Password Entry

Screenshots

No response

Example code

package main

func main() {
    ...

    entry := widget.NewEntry()
    entry.Password = true
    entry.Disable()

    ...
}

Fyne version

develop v2.3.4-rc1.0.20230516195251-56dd0f3e0f32

Go compiler version

1.20

Operating system and version

Windows 10

Additional Information

No response

@matwachich matwachich added the unverified A bug that has been reported but not verified label May 23, 2023
@Jacalz Jacalz added bug Something isn't working good first issue Good for newcomers and removed unverified A bug that has been reported but not verified labels May 24, 2023
@Jacalz
Copy link
Member

Jacalz commented May 24, 2023

Please write a fully run-able example code next time. I know that it might seem unnecessary and time consuming sometimes but it really is very helpful both when adding test cases and when testing pull requests, that fix the issue, locally.

@Jacalz Jacalz added this to the Fixes (v2.3.x) milestone May 24, 2023
@andydotxyz
Copy link
Member

Fixed on develop and release/v2.3.x branch ready for v2.3.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants