Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete Native Menu Implementation #682

Closed
Jonconradt opened this issue Feb 16, 2020 · 6 comments
Closed

Complete Native Menu Implementation #682

Jonconradt opened this issue Feb 16, 2020 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@Jonconradt
Copy link

Currently missing from native menus, see darwin implementation:

  • Enable/Disable a menu item
  • Separators
  • KeyEquivalents
  • Indentation levels

The Apple Documentation for MenuItem: https://developer.apple.com/documentation/appkit/nsmenuitem

While I realize that these seem like small things compared to the larger work that needs to be done, menus are a primary UX element for users. These small features would help the apps feel equivalent to other UX frameworks.

@andydotxyz
Copy link
Member

This would be great to add - but we will have to add support for those same things inside the Fyne canvas menus as well (for systems other than macOS).

Separator and disabled could be done relatively easily, indentation is tracked by another ticket (#395) but the key equivalents will take more work overall in the toolkit first.

@andydotxyz andydotxyz added the enhancement New feature or request label Feb 17, 2020
@toaster
Copy link
Member

toaster commented Apr 26, 2020

Separators were added to develop branch and will be part of 1.3.
Disabled menu items are planned but probably won’t be part of 1.3.
The same applies to KeyEquivalents (aka Shortcuts).

Regarding indentation: I don’t think that this is useful. Apples design documentation (https://developer.apple.com/design/human-interface-guidelines/macos/menus/menu-anatomy/) says:

Use a submenu instead of indenting menu items. Indentation results in an inconsistent interface and doesn’t express relationships between menu items. If you need to indent, then a submenu is a better choice.

Submenus probably will land in 1.3 (#905 is the first step here).

@toaster
Copy link
Member

toaster commented Apr 26, 2020

#905 now contains the support for native submenus, too

@ghost
Copy link

ghost commented Oct 10, 2020

See also #1372

@andydotxyz
Copy link
Member

I think the key equivalent / shortcut feature is the only remaining item

@andydotxyz
Copy link
Member

We think this is complete now in Bowmore release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants