Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ScrollToBottom and ScrollToTop #4492

Closed
wants to merge 6 commits into from
Closed

Fix ScrollToBottom and ScrollToTop #4492

wants to merge 6 commits into from

Conversation

lorypelli
Copy link

Description:

I managed to fix scroll to bottom issue, I tested and it works...

Fixes #2917

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

Where applicable:

  • Public APIs match existing style and have Since: line.
  • Any breaking changes have a deprecation path or have been discussed.
  • Check for binary size increases when importing new modules.

@lorypelli
Copy link
Author

Fixing ScrollToTop also

@lorypelli lorypelli changed the title Fix ScrollToBottom not working Fix ScrollToBottom and ScrollToTop Dec 29, 2023
@lorypelli lorypelli closed this Dec 29, 2023
@lorypelli lorypelli deleted the patch-1 branch December 29, 2023 12:34
@lorypelli lorypelli restored the patch-1 branch December 29, 2023 12:35
@lorypelli lorypelli reopened this Dec 29, 2023
@lorypelli
Copy link
Author

sorry, I tried to rename the branch but I wasn't able to

@lorypelli lorypelli changed the base branch from master to develop December 29, 2023 12:36
@lorypelli
Copy link
Author

ok, I will open a new pull request,,,

@lorypelli lorypelli closed this Dec 29, 2023
@lorypelli lorypelli deleted the patch-1 branch December 29, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

func (s *Scroll) ScrollToBottom() not scrolling
3 participants
@lorypelli @dweymouth @andydotxyz