fix: fix angular control block after @for
#78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `@empty` is optional but was being enforced as the next control block after a `@for` https://angular.dev/guide/templates/control-flow#providing-a-fallback-for-for-blocks-with-the-empty-block
|
@g-plane lol, thanks for cleaning up my logic. I definitely should have taken a step back to reflect after getting it working |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For angular
@forcontrol blocks the subsequent@emptyis optional (doc) but it was being enforced as the next control block after a@for.Tried to modify in alignment with how
parse_angular_ifwas handling the optional subsequent control blocks.Happy to fix up or or tweak as I didn't engage with too much of this code base when trying to fix this but it did resolve the errors I was getting when running on an Angular code base.
Output of added test cases without the code changes: