Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC-6838: parameter should not be specified more than once #3

Closed
g4s8 opened this issue Oct 3, 2017 · 7 comments
Closed

RFC-6838: parameter should not be specified more than once #3

g4s8 opened this issue Oct 3, 2017 · 7 comments

Comments

@g4s8
Copy link
Owner

g4s8 commented Oct 3, 2017

According to Parameter Requirements:

It is an error for a specific parameter to be specified more than once.

So lets change params() signature of MimeType from Map<String, List<String>> to
Map<String, String>. If parameter specified more than once params() should throw an exception.

@Viciouss
Copy link
Contributor

Viciouss commented Oct 3, 2017

Hi, I'd like to work on this. Is an IllegalStateException okay for this purpose?

@g4s8
Copy link
Owner Author

g4s8 commented Oct 4, 2017

Hi @Viciouss! Thanks for contributing. I'll look at your PR soon. About exception: it would be better to use checked one here, you can take IOException or another extended from IOException.

@g4s8 g4s8 added this to the 1.0 milestone Oct 4, 2017
@rultor rultor closed this as completed in 9c7ad49 Oct 4, 2017
@0crat
Copy link

0crat commented Oct 4, 2017

Oops! Job gh:g4s8/mime#3 was not in scope

@g4s8
Copy link
Owner Author

g4s8 commented Oct 4, 2017

@Viciouss thanks!

@g4s8
Copy link
Owner Author

g4s8 commented Oct 4, 2017

@rultor release, tag=0.2

@rultor
Copy link
Collaborator

rultor commented Oct 4, 2017

@rultor release, tag=0.2

@g4s8 OK, I will release it now. Please check the progress here

@rultor
Copy link
Collaborator

rultor commented Oct 4, 2017

@rultor release, tag=0.2

@g4s8 Done! FYI, the full log is here (took me 2min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants