Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

genomicVariations to return pathogenicity predictions #76

Open
dglemos opened this issue Apr 25, 2023 · 6 comments
Open

genomicVariations to return pathogenicity predictions #76

dglemos opened this issue Apr 25, 2023 · 6 comments

Comments

@dglemos
Copy link
Collaborator

dglemos commented Apr 25, 2023

Hello,
This is more of a question.
I need Beacon to return pathogenicity predictions such as CADD and EVE.
The current schema does not specify any field for these types of predictions.
Could we have a new section under VariantLevelData just for in silico predictions?

@mbaudis
Copy link
Member

mbaudis commented Apr 26, 2023

@dglemos I'm +1 for this; logical addition (although we at some point have to comb over the whole variant model anyway, especial regarding its integration w/ VRS 1.3++).

  VariantLevelData:
    type: object
    properties:
      clinicalInterpretations:
        type: array
        items:
          $ref: '#/definitions/PhenoClinicEffect'
      phenotypicEffects:
        type: array
        items:
          $ref: '#/definitions/PhenoClinicEffect'
      pathogenicityPredictions:
        type: array
        items:
          $ref: '#/definitions/PhenoClinicEffect'

... like that? And would the PhenoClinicEffect class be sufficient? Needs then also respective definitions/examples.

@costero-e Could you have a look into organizing this into the branch setup, e.g. which feature branch this should go to and set one up if needed? And feed back to @dglemos to give her a place to craft a PR against. We can edit.

@costero-e
Copy link
Collaborator

Yes @mbaudis , I will take a look at it tomorrow if the day gives me a chance as I have been very busy lately

@costero-e
Copy link
Collaborator

costero-e commented Apr 27, 2023

Alright, I have created a feature branch called genomicVariations and a subfeature branch called genomicVariations_add-pathogenicity-predictions. @dglemos you can modify this subfeature branch and PR to genomicVariations when you are ready

@dglemos
Copy link
Collaborator Author

dglemos commented May 3, 2023

@mbaudis @costero-e thank you for the response!
I'm working on the PR, it may take a few weeks to be ready though.
I'm also planning on adding other changes such as molecular interactions and a small update to the frequency schema.

@dglemos
Copy link
Collaborator Author

dglemos commented Jun 15, 2023

Hi @costero-e,
I'm unable to push changes to the branch genomicVariations_add-pathogenicity-predictions.
Can you please check the permissions?

@costero-e
Copy link
Collaborator

Hi @dglemos , I just sent you a collaboration request for you to be able to push into the branches. If you accept it you will be able to push now. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants