Feature/automated docker release #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct test tag, instead of tag test
jb-adams
requested changes
Jan 28, 2022
There was a problem hiding this comment.
releases.yml looks like it duplicates a lot of steps from tests.yml, like all the unit and docker testing. We want the release step to be dependent on unit and docker tests passing, but not for them to run twice.
Maybe it's best to put everything back into one file? And have a distinct Docker-Release job that needs Docker-Integration-Test to pass.
You could do something like:
jobs:
...
Docker-Release:
if: # expression to run when there's a merge into main
See the Github Actions docs for jobs and expressions
|
I just ran the tests without the main condition, and instead of a docker image with the tag test, the one with tag 0.5.7 was updated. |
jb-adams
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding issue #37:
Created a separate workflow file which is only to be triggered when there is a push happening in main (which will only happen when a PR is being merged from develop).
In this workflow, a docker image will be released with the correct tag.